reverseproxy: use DialTLSContext for TLS if servername has placeholder#6955
Merged
reverseproxy: use DialTLSContext for TLS if servername has placeholder#6955
Conversation
francislavoie
changed the title
Member
|
Thanks for this! Does this reduce any functionality though? It uses a single static transport -- definitely more efficient -- but less dynamic, right? |
Member
Author
|
The only dynamic part that I can think of is the server name placeholder part, which this patch takes care of. I haven't found any thing broken in my setup. |
mholt
approved these changes
Apr 28, 2025
Member
mholt
left a comment
mholt
left a comment
There was a problem hiding this comment.
I think we can give this a shot then. Thanks for the contribution, and if there's any reported issues, hopefully you can help us with them 😅
1 task
mohammed90
pushed a commit
to cedricziel/caddy
that referenced
this pull request
Aug 29, 2025
…server#6955) Co-authored-by: Matt Holt <mholt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way when using placeholders to establish tls connections, the performance can be significantly improved.
Also reduced the amount of codes that replicate the transport.